Fixing issue where long, unbroken strings in resource name cell URLs breaks layout

[rhamilto]

Fixes #1161

Plus bonus bug fix for Pods table where colspan was incorrect

@jwforres or @spadgett, PTAL. cc: @sg00dwin

[spadgett]

Should we apply the break-all styles to just the columns that need it? Some columns like status and relative times shouldn't need break-all.

[rhamilto]

Should we apply the break-all styles to just the columns that need it? Some columns like status and relative times shouldn't need break-all.

@sg00dwin, I was following your lead on this fix. What do you think?

[sg00dwin]

There is a .word-break-normal class that can be set on individual <td>, so we can isolate in those cases.

As for whether we should apply word-break-all by default... I assume it would depend on whether we think there's a greater risk of breaking content when it's not intended or not breaking long strings where needed. Either way we approach it, will require individual examination of a tables column content.

[spadgett]

I feel like we have the default backwards: we should only apply the style to the few columns that need it, not the whole table. I'd rather add word-break-all to the td elements that need it and remove the class that adds it to the whole table.

[rhamilto]

I switched the default to opt-in to word-break. PTAL @spadgett.

[rhamilto]

@spadgett, changed so that all td, th elements in .table-layout-fixed get word-break by default.

[spadgett]

I'm seeing at least one place (deployments page) where we have overlapping text, likely because we have a min-width on the column.

[spadgett]

Suggest we give less width to "Last Build" and more to "Created."

We might want duration value and unit to wrap together. (Doesn't have to be in this PR, but noticed while testing.)

@jwforres We might have too many columns in some of our tables :/

[spadgett]

We should consider updating build-config.html, deployment-config.html, deployment.html, and other-resources.html, too.

[rhamilto]

I'm seeing at least one place (deployments page) where we have overlapping text, likely because we have a min-width on the column.

I think it should be better now.

Suggest we give less width to "Last Build" and more to "Created."

Done. And now we hide "Source" at small viewport sizes. And fixed the th wrapping issue by removing word-break for th elements.

We should consider updating build-config.html, deployment-config.html, deployment.html, and other-resources.html, too.

Done:

• deployment.html
  
• other-resources.html
  

Not done as I don't think it's necessary (am I overlooking something on these?):

• build-config.html
  
• deployment-config.html
  

Let's give this another whirl, @spadgett?

[spadgett]

[merge]

[openshift-bot]

Evaluated for origin web console merge up to a8426d2

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/986/) (Base Commit: a506596)