Removing pficon variables (overrides) #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatternFly now includes these vars in its source less, so defining them in our less can (and will with PatternFly v3.23.0) result in a bug where icons disappear (PatternFly v3.23.0 changes the unicode values of a number of icons, thus causing the bug)
spadgett
approved these changes
Mar 16, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 704887b |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1159/) (Base Commit: 4bf3905) |
|
Yep what @rhamilto said, we needed the vars before they made it into Patternfly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PatternFly now includes these vars in its source less, so defining them
in our less can (and will with PatternFly v3.23.0) result in a bug
where icons disappear (PatternFly v3.23.0 changes the unicode values of
a number of icons, thus causing the bug).
@spadgett, PTAL