Update create/createFromImage to use new DataService.list #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
requested changes
Mar 17, 2017
| if ($filter('hashSize')(limitRanges) !== 0) { | ||
| DataService.list("limitranges", context).then(function(resp) { | ||
| $scope.limitRanges = resp.by("metadata.name"); | ||
| if ($filter('hashSize')(resp) !== 0) { |
There was a problem hiding this comment.
This was existing code, but we shouldn't check hashSize against the response itself. Let's change this to
if (!_.isEmpty($scope.limitRanges)) { ...
MarkDeMaria
force-pushed
the
promisesCreateFromImage
branch
from
cf5ae70 to
05f88d4
Compare
|
@spadgett Oops! Slipped by. Changes made. |
MarkDeMaria
force-pushed
the
promisesCreateFromImage
branch
from
05f88d4 to
7c5c76f
Compare
MarkDeMaria
force-pushed
the
promisesCreateFromImage
branch
from
7c5c76f to
f3eea74
Compare
spadgett
approved these changes
Mar 17, 2017
|
[merge] |
|
Jasmine timeout [merge] |
|
Evaluated for origin web console merge up to f3eea74 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1175/) (Base Commit: ea891ff) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make create/createFromImage promise compliant #799