Skip to content

Prevent cancel from submitting edit dc form #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Prevent cancel from submitting edit dc form #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/edit/deployment-config.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ <h1>
Edit Deployment Config {{deploymentConfig.metadata.name}}
</h1>
<fieldset ng-disabled="disableInputs">
<form class="edit-form" name="form" novalidate ng-submit="save()">
<form class="edit-form" name="form" novalidate>
<confirm-on-exit dirty="form.$dirty && !confirm.doneEditing"></confirm-on-exit>
<div class="row">
<div class="col-lg-12">
Expand Down Expand Up @@ -376,7 +376,7 @@ <h4>Container {{containerName}}</h4>
</pause-rollouts-checkbox>

<div class="buttons gutter-top-bottom">
<button type="submit" class="btn btn-primary btn-lg" ng-disabled="form.$invalid || form.$pristine || disableInputs">
<button ng-click="save()" class="btn btn-primary btn-lg" ng-disabled="form.$invalid || form.$pristine || disableInputs">
Save
</button>
<button ng-click="cancel()" class="btn btn-default btn-lg">Cancel</button>
Expand Down
4 changes: 2 additions & 2 deletions dist/scripts/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9361,7 +9361,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"Edit Deployment Config {{deploymentConfig.metadata.name}}\n" +
"</h1>\n" +
"<fieldset ng-disabled=\"disableInputs\">\n" +
"<form class=\"edit-form\" name=\"form\" novalidate ng-submit=\"save()\">\n" +
"<form class=\"edit-form\" name=\"form\" novalidate>\n" +
"<confirm-on-exit dirty=\"form.$dirty && !confirm.doneEditing\"></confirm-on-exit>\n" +
"<div class=\"row\">\n" +
"<div class=\"col-lg-12\">\n" +
Expand Down Expand Up @@ -9594,7 +9594,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<pause-rollouts-checkbox deployment=\"updatedDeploymentConfig\" always-visible=\"true\">\n" +
"</pause-rollouts-checkbox>\n" +
"<div class=\"buttons gutter-top-bottom\">\n" +
"<button type=\"submit\" class=\"btn btn-primary btn-lg\" ng-disabled=\"form.$invalid || form.$pristine || disableInputs\">\n" +
"<button ng-click=\"save()\" class=\"btn btn-primary btn-lg\" ng-disabled=\"form.$invalid || form.$pristine || disableInputs\">\n" +
"Save\n" +
"</button>\n" +
"<button ng-click=\"cancel()\" class=\"btn btn-default btn-lg\">Cancel</button>\n" +
Expand Down