Show toast notifications when attaching / removing PVCs #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
attach-remove-pvc-toasts
branch
from
22679e6 to
71cb917
Compare
jwforres
reviewed
Jun 7, 2017
app/scripts/controllers/attachPVC.js
Outdated
| var details; | ||
| if (!mountPath) { | ||
| // FIXME: This seems like a bad experience since we don't give users a way to mount it later. | ||
| details = "The volume was added, but not mounted, since no mount path given."; |
There was a problem hiding this comment.
can we get an issue open for this? or get it added as a gap in the trello story about pvc experience... that aside, can you update the text. Maybe "No mount path was provided. The volume reference was added to the configuration but it will not be mounted into running pods."
spadgett
force-pushed
the
attach-remove-pvc-toasts
branch
from
71cb917 to
1da7d0e
Compare
|
@jwforres thanks, updated |
jwforres
approved these changes
Jun 7, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 1da7d0e |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1483/) (Base Commit: ad1da6b) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6WVJdgjL