Show toast notifications when adding config files as volumes #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Jun 7, 2017
| type: "success", | ||
| message: "Succesfully added " + sourceKind + " " + source.metadata.name + | ||
| " to " + targetKind + " " + $routeParams.name + ".", | ||
| details: "Files mounted at path " + mountPath |
There was a problem hiding this comment.
should probably be a period at the end of the details sentence, and maybe say "The files will be mounted at the path <whatever>.
spadgett
force-pushed
the
add-config-files-toast
branch
from
305c383 to
2c6b5eb
Compare
|
@jwforres I removed the path from the message |
jwforres
approved these changes
Jun 7, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 2c6b5eb |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1484/) (Base Commit: a18e11e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6WVJdgjL