Show toast notifications in create from builder flow #1681
Conversation
| Logger, | ||
| MetricsService, | ||
| Navigate, | ||
| NotificationsService, |
There was a problem hiding this comment.
Only change to dependencies is NotificationsService. But I sorted and reformatted the list.
| @@ -313,16 +325,7 @@ angular.module("openshiftConsole") | |||
| } | |||
| ); | |||
| return d.promise; | |||
| }, | |||
| function(result) { // failure | |||
There was a problem hiding this comment.
assume DataService.batch was never resulting in a rejected promise?
There was a problem hiding this comment.
We were passing an extra argument to TaskList.add that it doesn't take :/
There was a problem hiding this comment.
ah yep didnt have my curly braces matched up right, got it.
There was a problem hiding this comment.
The indentation and nesting makes it really hard to follow in this file :(
|
[merge] |
|
Evaluated for origin web console merge up to 8bde33d |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1504/) (Base Commit: 07c5b8c) |
https://trello.com/c/6WVJdgjL