Fix awkward overview message for new deployments #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Jun 20, 2017
| @@ -39,7 +39,7 @@ | |||
| <div ng-if="row.apiObject.kind === 'DeploymentConfig'"> | |||
| <span class="mar-right-sm"> | |||
| <span class="hidden-xs"> | |||
| {{row.apiObject.spec.strategy.type}} deployment | |||
| {{row.apiObject.spec.strategy.type}} deployment is | |||
There was a problem hiding this comment.
will that work for all statuses?
There was a problem hiding this comment.
It should:
is new
is pending
is running
is complete
is failed
jwforres
approved these changes
Jun 20, 2017
|
[merge][severity:bug] |
|
Evaluated for origin web console merge up to fd77ade |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1571/) (Base Commit: eaa5d82) (PR Branch Commit: fd77ade) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1692