Use config.local.js if present for grunt serve:dist #1796
Conversation
|
|
||
| // If config.local.js exists, use that instead of config.js. | ||
| if (grunt.file.exists('app/config.local.js')) { | ||
| rewriteRules.unshift('^/config.js$ /config.local.js [L]'); |
There was a problem hiding this comment.
is this how we are doing it for the dev server? the only problem i see with this is that if you delete your config.local.js file you have to restart your grunt server
There was a problem hiding this comment.
No, we copy the config.local.js to .tmp for grunt serve, but I don't think that works here.
https://github.com/openshift/origin-web-console/blob/master/Gruntfile.js#L552-L563
I suspect copying has the same problem when you delete the file.
There was a problem hiding this comment.
Ok, not a big deal since we rarely create/delete them
|
[merge] going ahead and merging since this doesn't affect shipped code |
|
Evaluated for origin web console merge up to d135a99 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1620/) (Base Commit: 5fdc228) (PR Branch Commit: d135a99) |
Fixes #1795