Skip to content

Add application launcher example to constants.js #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

Add application launcher example to constants.js #1883

merged 1 commit into from
Jul 27, 2017

Conversation

spadgett
Copy link
Member

No description provided.

@dtaylor113
Copy link
Contributor

LGTM. For what it's worth, here is the example I use:

APP_LAUNCHER_NAVIGATION: [
    {
      title: "App One",
      href: "#/ipsum/intellegam/recteque",
      tooltip: "Launch the Function User Interface",
      iconClass: "pficon pficon-storage-domain"
    },
    {
      title: "App Two",
      href: "#/ipsum/intellegam/suavitate",
      tooltip: "Launch the Function User Interface",
      iconClass: "pficon pficon-build"
    },
    {
      title: "App Three",
      href: "#/ipsum/intellegam/lorem",
      tooltip: "Launch the Function User Interface",
      iconClass: "pficon pficon-project"
    },
    {
      title: "App Four",
      href: "#/ipsum/intellegam/home",
      tooltip: "Launch the Function User Interface",
      iconClass: "pficon pficon-home"
    }
  ]

@spadgett spadgett force-pushed the app-launcher-example branch from f1823e3 to 13ea8e8 Compare July 27, 2017 13:00
jeff-phillips-18
jeff-phillips-18 approved these changes Jul 27, 2017
View reviewed changes
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one nit, otherwise LGTM

app/scripts/constants.js Outdated
],
APP_LAUNCHER_NAVIGATION: [
// Example application link to show in the masthead applciation launcher beside the help and logout icons.
// {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in application

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@spadgett spadgett force-pushed the app-launcher-example branch from 13ea8e8 to a45a3de Compare July 27, 2017 13:13
@spadgett
Copy link
Member Author

[merge][severity:lowrisk]

@spadgett
Copy link
Member Author

Flake #1684

[merge][severity:lowrisk]

@openshift-bot
Copy link

Evaluated for origin web console merge up to a45a3de

@openshift-bot
Copy link

openshift-bot commented Jul 27, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/57/) (Base Commit: 91f326c) (PR Branch Commit: a45a3de) (Extended Tests: lowrisk)

@openshift-bot openshift-bot merged commit dca60ca into openshift:master Jul 27, 2017
@spadgett spadgett deleted the app-launcher-example branch July 27, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @dtaylor113 @openshift-bot @jeff-phillips-18