Fix runtime error on deploy image page

[spadgett]

The ng-form was not correctly initialized, resulting in a runtime error.

Cherry picked from branch enterprise-3.6 (#1887)

@rhamilto

[spadgett]

[test]

[jeff-phillips-18]

LGTM. However, thinking about this last night (after approving the 3.6 changes), Initializing $scope.forms in the controller rather than the link function would probably fix the errors as well. Sorry for the delayed thoughts.

[spadgett]

@jeff-phillips-18 Ah, I think you're probably right. I'll try it this morning and update the PR. I'm inclined to leave the enterprise-3.6 fix alone since I know it works and I've done quite a bit of testing.

@benjaminapetersen FYI, see Jeff's comment above.

[spadgett]

@jeff-phillips-18 Your suggestion worked 👍

Thanks, this looks much cleaner.

[openshift-bot]

Evaluated for origin web console test up to 2560a9f

[openshift-bot]

Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/31/) (Base Commit: f62c98f) (PR Branch Commit: 2560a9f)

[spadgett]

@jeff-phillips-18 another look for my updates?

[jeff-phillips-18]

👍

[spadgett]

@jeff-phillips-18 Thanks!

[merge][severity: blocker]

[openshift-bot]

Evaluated for origin web console merge up to 2560a9f

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/60/) (Base Commit: 4bcfb4f) (PR Branch Commit: 2560a9f) (Extended Tests: blocker)