Add a Safari Pinned Tab Icon #1909
Conversation
ptescher
changed the title
|
@pat2man |
|
@sg00dwin 😬 rebased. |
| <svg width="16px" height="16px" viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <!-- Generator: Sketch 46 (44423) - http://www.bohemiancoding.com/sketch --> | ||
| <title>mask-icon</title> | ||
| <desc>Created with Sketch.</desc> |
There was a problem hiding this comment.
If it's not against the T&C for Sketch, I'd rather remove the description here and generator comment above.
There was a problem hiding this comment.
@spadgett that makes sense but all the other SVGs also have the generator comment: https://github.com/openshift/origin-web-console/blob/master/app/images/logo-origin-thin.svg?short_path=fe5e643#L3
There was a problem hiding this comment.
Thanks for checking that. I'm not worried about it then
Icon adopted from openshift-logo.svg Reference document: https://developer.apple.com/library/content/documentation/AppleApplicati ons/Reference/SafariWebContent/pinnedTabs/pinnedTabs.html
|
@spadgett ran |
|
Thanks @pat2man [merge] |
|
Evaluated for origin web console merge up to 5720905 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/67/) (Base Commit: 7a25f13) (PR Branch Commit: 5720905) |
Icon adopted from openshift-logo.svg
Reference document: https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/pinnedTabs/pinnedTabs.html