Skip to content

Prefill service labels when creating route #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Aug 15, 2017

Prefill the labels from the service by default when creating a route without making the user click "Copy Service Labels."

Fixes #1934

Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spadgett spadgett force-pushed the route-service-labels branch from f2878df to b6c96b9 Compare August 15, 2017 20:34
@spadgett
Copy link
Member Author

[merge][severity: bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to b6c96b9

@openshift-bot
Copy link

openshift-bot commented Aug 15, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/75/) (Base Commit: e89bb67) (PR Branch Commit: b6c96b9) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit 179deb2 into openshift:master Aug 15, 2017
@spadgett spadgett deleted the route-service-labels branch August 15, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants