Bug 1527689 - Let users add the same PVC multiple times #2859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the same volume name if the PVC has already been added as a volume to a pod template. This lets users add the same volume more than once using different mount paths / subpaths. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527689
openshift-ci-robot
added
the
size/M
|
This fixes #1665 in that you can now later add a mount path by adding the PVC again, but it still seems strange to me that we don't just make mount path required. |
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the same volume name if the PVC has already been added as a volume
to a pod template. This lets users add the same volume more than once
using different mount paths / subpaths.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527689
Closes #1665
/assign @jwforres
/cc @erinboyd @zherman0