etcd clients and wrapping

[timothysc]

We're using 3 different clients, some are reaching through directly vs. using wrapped storage layer.

Clients include:
etcd3-v2-client
etcd3-v3-client
go-etcd (old) client

Version

latest master

Upstream we've wrapped all invocations through a factory in the storage layer, we should push all these instances through a similar mechanism or wrap appropriately to allow for switch, as etcd3 does not support a mixed-mode data. e.g. - registry using v3mode, locking + other stuff using v2mode

/cc @brenton @smarterclayton @mffiedler

[smarterclayton]

etcd3 does not support old and new keys at the same time?

[timothysc]

So word is the etcd folks are trying to create a v2 proxy that supports v2 API on top of 3, but mixed mode is not supported, as mixed mode snapshotting + backup and recovery wouldn't make any sense b/c the data formats are incompatible.

[smarterclayton]

We don't need backup for the election service though. It's not a huge deal
to change though

On Oct 25, 2016, at 9:45 PM, Timothy St. Clair notifications@github.com
wrote:

So word is the etcd folks are trying to create a v2 proxy that supports v2
API on top of 3, but mixed mode is not supported, as mixed mode
snapshotting + backup and recovery wouldn't make any sense b/c the data
formats and incompatible.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11573 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p--pViz1oo2SLp5ksPjwehho2_gVks5q3rCfgaJpZM4KgiJf
.

[smarterclayton]

I don't think we should be using go-etcd anywhere anymore. Just haven't
removed the helper method that is unused.

I was completely unaware side by side v2/v3 mode was unsupported in the v3
client library.

On Tue, Oct 25, 2016 at 5:58 PM, Timothy St. Clair <notifications@github.com

wrote:

We're using 3 different clients, some are reaching through directly vs.
using wrapped storage layer.

Clients include:

etcd3-v2-client
etcd3-v3-client
go-etcd (old) client
Version

latest master

Upstream we've wrapped all invocations through a factory in the storage
layer, we should push all these instances through a similar mechanism or
wrap appropriately to allow for switch, as etcd3 did not support a
mixed-mode data. e.g. - registry using v3mode, locking + other stuff using
v2mode

/cc @brenton https://github.com/brenton @smarterclayton
https://github.com/smarterclayton @mffiedler
https://github.com/mffiedler

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11573, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_pwjUpOWWVYdNA5S0OqqDq08XOPNgks5q3nuHgaJpZM4KgiJf
.

[danmcp]

@mfojtik Tim is concerned about releasing the code as is. Need to get that resolved.

[mfojtik]

@smarterclayton we still use go-etcd in pkg/cmd/server/etcd/etcd.go but I guess we can replace it with the helper.