Skip to content

openshift start master should not automatically create a node entry #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sosiouxme opened this issue Feb 26, 2015 · 2 comments · Fixed by #1182
Closed

openshift start master should not automatically create a node entry #1161

sosiouxme opened this issue Feb 26, 2015 · 2 comments · Fixed by #1182
Assignees
@deads2k
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@sosiouxme
Copy link
Member

While it is helpful for openshift start to automatically add $(hostname -f) as a node for the 30-second all-in-one startup scenario, this is not desirable when starting just the master; nodes should be added explicitly, and we can't assume the master will be one. The self entry in that case is likely to confuse and, being defined automatically, may not specify resource availability consistently with the way other nodes are defined even if it is desired.

We discussed other flags for preventing auto-adding self as node at startup, but the simplest/clearest approach seems to be to distinguish openshift start (where you would need and expect self to be added) from openshift start master (where you would not).
@brenton
Copy link
Contributor

brenton commented Feb 26, 2015

+1

@brenton brenton added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2015
@brenton
Copy link
Contributor

brenton commented Feb 27, 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1191357

@deads2k deads2k mentioned this issue Feb 27, 2015
Merged
brenton added a commit to brenton/origin that referenced this issue Feb 27, 2015
@brenton
openshift start master should not automatically create a node entry o…
604e0ae 
…penshift#1161
jpeeler pushed a commit to jpeeler/origin that referenced this issue Sep 5, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
03955cd 
…service-catalog/' changes from 7e650e7e39..ef63307bdb

ef63307bdb origin build: add origin tooling
a876fe3 v0.0.17 (openshift#1178)
c5237fe correct osbapi service definition (openshift#1177)
6036d4e Adding walkthrough instructions for 1.7 (openshift#1171)
5f111dd Specifying that you need Helm v2.5.0 for installation (openshift#1170)
08043bd Adding more small fixes to the walkthrough & install docs (openshift#1169)
d65d4a1 rbac targets needed to be renamed as well (openshift#1161)
590f6f2 Write helm command to file for api aggregation (openshift#1141)
49ddcf6 clean before building a specific arch (openshift#1168)
43f7cfb Splitting up the Walkthrough for 1.6 and 1.7 instructions (openshift#1163)
02e0217 Updates to README (openshift#1166)
57f2aa5 Adding instructions for installing from Macs (openshift#1164)
dfe620e fix rate-limiting for polling queue (openshift#1143)
ca5f335 Use Generation instead of checksum for Broker (openshift#1145)
5364daa Merge branch 'pr/1158'
f34c5db move Travis deployment script to directory in 'contrib/'
2a00d7f Update incorrect port (openshift#1156)
b0ed60e improve the repository's layout (openshift#1154)
f870baf Follow up file / renames from openshift#1142 (openshift#1152)
826b4f9 remove unnecessary json annotations (openshift#1153)
33cb345 Rename resources. closes openshift#1080 (openshift#1142)
70c2b9b Add ability to specify CA certs to use for TLS authentication. (openshift#1112)
2aa5039 v0.0.16 (openshift#1140)
65de49c Comments for unit test bullet proofing (openshift#1139)
REVERT: 7e650e7e39 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: ef63307bdbaa64efca204912f5361a4f3d3be2c8
jpeeler pushed a commit to jpeeler/origin that referenced this issue Sep 11, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
2b7c9ef 
…service-catalog/' changes from 7e650e7e39..ef63307bdb

ef63307bdb origin build: add origin tooling
a876fe3 v0.0.17 (openshift#1178)
c5237fe correct osbapi service definition (openshift#1177)
6036d4e Adding walkthrough instructions for 1.7 (openshift#1171)
5f111dd Specifying that you need Helm v2.5.0 for installation (openshift#1170)
08043bd Adding more small fixes to the walkthrough & install docs (openshift#1169)
d65d4a1 rbac targets needed to be renamed as well (openshift#1161)
590f6f2 Write helm command to file for api aggregation (openshift#1141)
49ddcf6 clean before building a specific arch (openshift#1168)
43f7cfb Splitting up the Walkthrough for 1.6 and 1.7 instructions (openshift#1163)
02e0217 Updates to README (openshift#1166)
57f2aa5 Adding instructions for installing from Macs (openshift#1164)
dfe620e fix rate-limiting for polling queue (openshift#1143)
ca5f335 Use Generation instead of checksum for Broker (openshift#1145)
5364daa Merge branch 'pr/1158'
f34c5db move Travis deployment script to directory in 'contrib/'
2a00d7f Update incorrect port (openshift#1156)
b0ed60e improve the repository's layout (openshift#1154)
f870baf Follow up file / renames from openshift#1142 (openshift#1152)
826b4f9 remove unnecessary json annotations (openshift#1153)
33cb345 Rename resources. closes openshift#1080 (openshift#1142)
70c2b9b Add ability to specify CA certs to use for TLS authentication. (openshift#1112)
2aa5039 v0.0.16 (openshift#1140)
65de49c Comments for unit test bullet proofing (openshift#1139)
REVERT: 7e650e7e39 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: ef63307bdbaa64efca204912f5361a4f3d3be2c8
jpeeler pushed a commit to jpeeler/origin that referenced this issue Feb 1, 2018
@MHBauer @pmorie
rbac targets needed to be renamed as well (openshift#1161)
d65d4a1 
- 2238f51af901fe6bb722f108ce7c073b959333c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deads2k deads2k

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix nodelist defaulting deads2k/origin
3 participants
@brenton @sosiouxme @deads2k