oadm router should let me specify --requests and --limits #8328
Assignees
Labels
Comments
JacobTanenbaum
added a commit
to JacobTanenbaum/origin
that referenced
this issue
Apr 13, 2016
Add the ability to specify resource quotas on a router when it is created using the "oadm router" command. When creating a router without requests or limits oadm returns a warning that it is not recommended to run a router without resource quotas. addresses: openshift#8328
JacobTanenbaum
added a commit
to JacobTanenbaum/origin
that referenced
this issue
Apr 13, 2016
Add the ability to specify resource quotas on a router when it is created using the "oadm router" command. When creating a router without requests or limits oadm returns a warning that it is not recommended to run a router without resource quotas. if the limits or requests are not not passed the the router is still built but a warning is returned that it is not advised to run a router without requests and limits in a production environment Also adds the flags help text to oadm help router addresses: openshift#8328
|
Should the same be true of the registry? @detiber does the installer set limits/requests or allow them to be set? |
Yes #8329 |
JacobTanenbaum
added a commit
to JacobTanenbaum/origin
that referenced
this issue
Apr 14, 2016
Add the ability to specify resource quotas on a router when it is created using the "oadm router" command. When creating a router without requests or limits oadm returns a warning that it is not recommended to run a router without resource quotas. if the limits or requests are not not passed the the router is still built but a warning is returned that it is not advised to run a router without requests and limits in a production environment Also adds the flags help text to oadm help router addresses: openshift#8328
|
@eparis it does not currently, once the command line support for this lands, we can add the ability to set it (for versions of Origin/OSE that support the flags) |
|
request/limit is now included as a default part of the object that is generated by the command. Being able to set it during creation would still be a good enhancment |
|
I think we said that if you need this you can pipe
…On Mon, Jun 26, 2017 at 6:13 AM, Paul Weil ***@***.***> wrote:
request/limit is now included as a default part of the object that is
generated by the command. Being able to set it during creation would still
be a good enhancment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pw7dNMsdN-W0zNED6D4XsSypfycuks5sH4RjgaJpZM4H9t9z>
.
|
sgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
oadm routercommand should promote users specifying --requests and --limits for cpu and memory as it is a piece of critical infrastructure that should not run with best effort quality of service on nodes.The system should warn users that running a router with no requests and limits is bad practice in production.
Documentation should emphasize that this is bad practice.
/cc @pweil- @ncdc @eparis @smarterclayton
The text was updated successfully, but these errors were encountered: