Skip to content

[POC] restrict images at the kubelet #10114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 29, 2016

Demonstrates a kubelet patch that could be used to restrict images stored in the openshift API with "images.openshift.io/deny-execution" = "true". The kubelet could hold an LRU of images. The biggest downside is carrying a kubelet patch, though I'd expect a webhook of some kind here eventually.

@smarterclayton

@deads2k
Copy link
Contributor Author

deads2k commented Jul 29, 2016

Oh, and builds are the red-headed step children. You'd have to update the build code to perform a similar check, though if we did this it would be non-contentious.

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 30, 2016 via email

@deads2k
Copy link
Contributor Author

deads2k commented Jul 30, 2016

I've got an alternate admission controller I'd like to use instead

So do I, but I think it takes two. I'd like to see this restriction in 1.3. See #10116 for where I ended up.

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 30, 2016 via email

@deads2k
Copy link
Contributor Author

deads2k commented Jul 31, 2016

#8995 adds a lot of API and policy to this. You want to deal with a that right now or should we enable a very simple, zero config option now and add a full thought out policy based on later?

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 31, 2016 via email

@deads2k
Copy link
Contributor Author

deads2k commented Jul 31, 2016

If you're willing to cut deeply into your existing pull, I think we could make that work. I really like the idea of having an ootb annotation that will mostly do what an admin needs.

I'm less sure of rushing through a bypass mechanism, because I think it's closely tied to PSP and carrying patches in that area has been painful for us in the past.

@smarterclayton
Copy link
Contributor

Yeah I'm not sure about bypass but I want to be really careful. Ops
teams don't want their cluster taken down (registry / router / logging
/ metrics) if an image gets tagged as being potentially insecure.
Can talk tomorrow.

@deads2k deads2k closed this Aug 2, 2016
@deads2k deads2k deleted the restrict-images branch September 6, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants