Ensure only endpoints are specified in oc idle
#10335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed with Solly, waiting on a test case before merging |
DirectXMan12
force-pushed
the
bug/idling-rc-panic
branch
from
2b90072 to
8ff6422
Compare
|
I added a test in test/cmd |
When you call `oc idle` with only names, it treats those names as endpoints. However, if you manually specify a different resource in "resource/name" format, `oc idle` would panic, as it was expecting only endpoints. This commit throws an error instead when this situation is encountered.
The `oc idle` help text mentioned the `-f` flag, which got renamed to the `--resource-names-file` argument, but did not get changed in the example. This fixes that.
|
[test] |
|
Evaluated for origin test up to 8ff6422 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7750/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7769/) (Image: devenv-rhel7_4805) |
|
Evaluated for origin merge up to 8ff6422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you call
oc idlewith only names, it treats those names asendpoints. However, if you manually specify a different resource
in "resource/name" format,
oc idlewould panic, as it was expectingonly endpoints. This commit throws an error instead when this situation
is encountered.
This PR also contains a fix for a typo in the
oc idlehelp text.Fixes bug 1365838
Fixes bug 1365803