Changes the signature of CloneWithOptions function #10366
Conversation
|
[test] |
| // We need to check to see if we're importing reference information, for | ||
| // for error checking later on | ||
| for _, opt := range gitArgs { | ||
| if opt == "--depth=1" { |
There was a problem hiding this comment.
since we're matching between two places, "--depth=1" should be defined as a constant so they don't get out of sync in the future.
There was a problem hiding this comment.
I'm unsure of what you mean, should I add a "shallowGitArgs[]" array at the top?
There was a problem hiding this comment.
you should define a constant string for the "--depth=1" value and use it everywhere you've currently hardcoded the "--depth=1" string value. That should be sufficient.
bparees
changed the title
|
one nit and then lgtm for a post 1.3 merge. |
openshift-bot
added
the
needs-rebase
|
@oatmealraisin needs a rebase |
We change it to a packed string from a boolean struct. This allows us to use every option for clone, creating more utility for the package.
|
@bparees Rebased |
openshift-bot
removed
the
needs-rebase
|
flake #11024 |
bparees
changed the title
|
[testextended][extended:core(builds)] |
|
Evaluated for origin test up to a58fdcb |
|
Evaluated for origin testextended up to a58fdcb |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9047/) |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/496/) (Extended Tests: core(builds)) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9047/) (Image: devenv-rhel7_5049) |
|
Evaluated for origin merge up to a58fdcb |
We change it to a packed string from a boolean struct. This allows us
to use every option for clone, creating more utility for the package.
@bparees ptal? What do you think?