Implement a Template REST endpoint using the generic store

[smarterclayton]

• Expose /templates
• Add a simple describer and get printer for cli
• Changes /templateConfigs to use a looser validation (only parameters are checked)
• Makes template parameter "Value" override "Generate" (like Name and GenerateName, and so clients can preserve recorded values)
• The internal item array on Templates is now called "Objects" to prevent templates from being treated like lists.
• Switch end-to-end to fetch from the server
• Tests in test-cmd.sh

@mfojtik / @bparees review the changes being made

[smarterclayton]

This is code complete, @jwforres as well

[bparees]

this is going to be confusing behavior for users i think. (that you are creating a template object, not creating the things defined in the template). can't immediately think of a way to fix it that retains consistency with the create verb, but it bothers me so i figured i'd note it in case someone else has a thought.

[smarterclayton]

Create shouldn't create the things in the template anyway (otherwise the template isn't providing value) but yes, I agree.

[jwforres]

I created your examples/sample-app/application-template-dockerbuild.json as an example. The osc get templates output is only saying "3 generated" under parameters but the describe output shows 4 parameters (one of which is not generated).

[jwforres]

In osc describe template foo the output labels Parameter 1|2|3|etc and Object 1|2|3|etc are really redundant. would be better if it was something like:

Parameters:
    Name:       ADMIN_USERNAME
    Description:    administrator username
    Generated:  expression
    From:       admin[A-Z0-9]{3}

    Name:       ADMIN_PASSWORD
    Description:    administrator password
    Generated:  expression
    From:       [a-zA-Z0-9]{8}

Objects:
    Service             frontend
    Route               route-edge
    ImageRepository     origin-ruby-sample
    ImageRepository     ruby-20-centos

[smarterclayton]

@jwforres i agree that's better, we should enforce that across all commands that are doing nesting in a future sprint - @deads2k @ironcladlou @mfojtik

[smarterclayton]

@jwforres on the numbers, bens comments are still relevant. How do we convey maximal info about params in minimal space?

[smarterclayton]

Comments addressed

[bparees]

Still bothers me that you're printing either "blank" or "generated" here, rather than both if both apply.

[smarterclayton]

Generated really isn't that important in the grand scheme of things. We can always tweak it later.

----- Original Message -----

•   }
  

•   if len(p.Generate) > 0 {
  

•       generated++
  

•       continue
  

•   }
  

•   empty++
  

• }
• params := ""
• switch {
• case empty > 0:

•   params = fmt.Sprintf("%d (%d blank)", total, empty)
  

• case generated > 0:

•   params = fmt.Sprintf("%d (%d generated)", total, generated)
  

• default:

•   params = fmt.Sprintf("%d (all set)", total)
  

• }

Still bothers me that you're printing either "blank" or "generated" here,
rather than both if both apply.

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1040/files#r24853632

[smarterclayton]

I gets impatient - will take more comments as a follow on [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/953/) (Image: devenv-fedora_824)

[smarterclayton]

with feeling, [merge]

[openshift-bot]

Evaluated for origin up to a4e6609