You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When evacuating selected pods with command oadm manage-node <mynode> --evacuate --pod-selector="<service=myapp>", if there are no fit pods found, the command won't give any prompt. Users don't know what happened. Does the command execute successfully? Has any pod been evacuated? We'd better return an error if no pods found and the error info will be printed at terminal.
Not sure about this. Evacuating pods could be a precondition in a script, which must succeed before taking some other action. If all the pods with a given label selector are already evacuated (Length is 0), that is not an error
Agreed. But we'd better return when Length is 0, anyway. We can give prompt info by fmt.Print and return nil instead of error. This will help users to know what's going on when they execute the command in CLI. To be honest, I was confused when I got nothing outputed:) @liggitt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xiangpengzhao
force-pushed
the
fix-evacuate-no-pod
branch
from
When evacuating selected pods with command
oadm manage-node <mynode> --evacuate --pod-selector="<service=myapp>", if there are no fit pods found, the command won't give any prompt. Users don't know what happened. Does the command execute successfully? Has any pod been evacuated? We'd better return an error if no pods found and the error info will be printed at terminal./cc @fabianofranz Thanks!