generate_vrrp_sync_groups calls expand_ip_ranges on an already expanded ranges #10498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed ranges
broken version generates :
vrrp_sync_group group_OpenShift_IPFailover {
group {
OpenShift_IPFailover_VIP_1 # VIP 1.2.3.41.2.3.51.2.3.6
}
}
patched version generates :
vrrp_sync_group group_OpenShift_IPFailover {
group {
OpenShift_IPFailover_VIP_1 # VIP 1.2.3.4
OpenShift_IPFailover_VIP_2 # VIP 1.2.3.5
OpenShift_IPFailover_VIP_3 # VIP 1.2.3.6
}
}
stevekuznetsov
changed the title
|
@cameronbraid thx for the fix |
|
@knobunc / @rajatchopra merge magic please. Thx |
|
Evaluated for origin test up to 2646fe3 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8193/) |
|
[merge] |
|
Evaluated for origin merge up to 2646fe3 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8193/) (Image: devenv-rhel7_4871) |
|
This is bug 1365191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken version generates :
patched version generates :