Emit event when cancelling a deployment #10590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kargakis ptal |
| @@ -185,6 +185,7 @@ func (c *DeploymentController) Handle(deployment *kapi.ReplicationController) er | |||
| if err := c.cleanupDeployerPods(deployment); err != nil { | |||
| return err | |||
| } | |||
| c.emitDeploymentEvent(deployment, kapi.EventTypeNormal, "DeploymentCancelled", fmt.Sprintf("deployment %q cancelled", deployutil.LabelForDeployment(deployment))) | |||
There was a problem hiding this comment.
ruby-ex-8: Deployment "test/ruby-ex-8" cancelled seems weird :-)
There was a problem hiding this comment.
(but I don't care enough to keep it, so I will fix it :)
There was a problem hiding this comment.
Oh, I thought "deployment" was the first word in the event. :D
|
One comment, lgtm otherwise |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8390/) (Image: devenv-rhel7_4918) |
|
Evaluated for origin merge up to c374c50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple addition that allow to see the cancelled deployments in events (oc describe/console):