Add a line break when no events in describe #10653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarterclayton PTAL |
|
[test] |
fabianofranz
changed the title
fabianofranz
force-pushed
the
bugs_1369321
branch
from
e47f46b to
cf7a39f
Compare
|
Evaluated for origin test up to cf7a39f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8458/) |
|
CC @liggitt |
|
[merge] LGTM |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8458/) (Image: devenv-rhel7_4929) |
|
Evaluated for origin merge up to cf7a39f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPSTREAM: kubernetes/kubernetes#31463
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1369321
Adds a line break in the events describer in case of no events. Without this fix, after kubernetes/kubernetes@6caf4d5 a describe without events would result in no line break before exiting to terminal.