Restore the service proxier when unidling is disabled

[knobunc]

The unidling code change had inadvertently removed the proxier when
idling was disabled. This change restores the default proxier
(userspace or iptables depending on the config).

Bug 1370435

[knobunc]

@DirectXMan12 PTAL

[knobunc]

[test]

[knobunc]

@DirectXMan12 on line 479 is it okay to call SyncLoop on the idler proxy (or is it even preferable?)

[DirectXMan12]

@knobunc yeah, we should have been calling it on the hybrid proxy all along. We didn't "miss" it because the functionality in the userspace proxy's sync code is just ensurePortals and a bit of extra periodic cleanup on an internal hashmap in the loadbalancer, both of which are taken care of in some form or another at other points in the code. We do actually want to do the normal periodic checks and cleanup, so calling the hybrid proxy's SyncLoop (which calls Sync on both the iptables proxy and the unidling userspace proxy) is preferable.

[ncdc]

[testextended][extended:core(idling)]

[knobunc]

[testextended][extended:core(idling)]

[knobunc]

[testextended][extended:core(idling)]

[knobunc]

[testextended][extended:core(idling)]

[openshift-bot]

Evaluated for origin testextended up to 07c01a6

[openshift-bot]

Evaluated for origin test up to 07c01a6

[openshift-bot]

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/446/) (Extended Tests: core(idling))

[ncdc]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8507/) (Image: devenv-rhel7_4939)

[openshift-bot]

Evaluated for origin merge up to 07c01a6

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8507/)

[knobunc]

I entered https://bugzilla.redhat.com/show_bug.cgi?id=1370680 so we remember to reenable the UDP test.