UPSTREAM: 31627: make deep copy of quota objects before mutations

[deads2k]

The code currently makes shallow copies which ensures that we aren't accidentally reslicing anything in weird ways, but the usage maps are pointers, so they end up being shared.

This makes a couple copies when we know we're going to mutate to avoid changing shared maps.

I found this while investigating another problem. [test]

@derekwaynecarr origin pick of upstream change

[openshift-bot]

Evaluated for origin test up to e815e5b

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8529/)

[deads2k]

@mfojtik lgtm'ed upstream. We should have this.

[deads2k]

@liggitt looking for a second before merging

[liggitt]

LGTM

[deads2k]

[merge]

[derekwaynecarr]

@deads2k @smarterclayton - should this have actually merged?

On Friday, September 2, 2016, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge ABORTED (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8670/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10704 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF8dbJkD7jTY5w3fEF76ZhlxVhBGvayxks5qmLM2gaJpZM4Jvuet
.

[liggitt]

[merge]

[openshift-bot]

Evaluated for origin merge up to e815e5b

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8694/) (Image: devenv-rhel7_4977)