Ensure system:master has full permissions on non-resource-urls #10851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deads2k PTAL |
|
cc @enj |
|
1.3.1 since a reconcile by the cluster admin during upgrade will update the discovery role |
|
Does this need any tests? |
|
lgtm, merge at will. |
|
added a covers test |
|
[merge] |
|
Evaluated for origin merge up to fde8054 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to fde8054 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8909/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8911/) (Image: devenv-rhel7_5021) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10785 and https://bugzilla.redhat.com/show_bug.cgi?id=1372579
Note that a role reconcile as a cluster-admin is needed when upgrading from before 1.3/3.3