Etcd v3.1.0-alpha.0 with embedding and gRPC support #10976

smarterclayton · 2016-09-18T02:07:16Z

No description provided.

smarterclayton · 2016-09-18T16:35:45Z

[test]

smarterclayton · 2016-09-19T05:07:08Z

[test]

smarterclayton · 2016-09-19T05:08:00Z

Flaked on rollout history on deployments. We appear to be unable to schedule more pods - the service endpoints test, this test, and the deploy iteratively test all rely on having enough room to schedule. We need to add debugging to it.

smarterclayton · 2016-09-20T03:02:40Z

@liggitt if you can review the etcd master server startup change.

smarterclayton · 2016-09-20T05:48:09Z

hack/test-cmd.sh has failed: idle.sh:34: executing 'oc get pod -l app=idling-echo -o go-template='{{ len .items }}'' expecting any result and text '2'; re-trying every 0.2s until completion or 60.000s

[test]

smarterclayton · 2016-09-20T13:14:44Z

[test]

smarterclayton · 2016-09-21T01:11:57Z

[test]

smarterclayton · 2016-09-26T19:57:14Z

[test]

smarterclayton · 2016-09-26T22:05:57Z

@liggitt review

On Mon, Sep 26, 2016 at 4:02 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test Running (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9313/)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10976 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_pxl48rTeZ5wNI5l3Lvxfqpq-_BK2ks5quCTsgaJpZM4J_xaZ
.

liggitt · 2016-09-27T14:26:27Z

if someone starts an existing data store with this, it'll be impossible for them to roll back to an older version of origin, right? if so, worth noting in the release notes

liggitt · 2016-09-27T14:20:23Z

hack/install-etcd.sh

@@ -23,10 +23,6 @@ fi

 # setup a private GOPATH so the build can succeed
 export GOPATH="${PWD}/gopath"
-rm -f "${GOPATH}/src/github.com/coreos/etcd"
-mkdir -p "${GOPATH}/src/github.com/coreos"
-ln -s "${PWD}" "${GOPATH}/src/github.com/coreos/etcd"


what was the original reason for this, and why is it no longer needed?

etcd ./build does this now - they didn't used to control their gopath, now they do

liggitt · 2016-09-27T14:20:52Z

test/cmd/basicresources.sh

@@ -26,7 +26,8 @@ os::test::junit::declare_suite_start "cmd/basicresources/versionreporting"
 os::build::get_version_vars
 os_git_regex="$( escape_regex "${OS_GIT_VERSION%%-*}" )"
 kube_git_regex="$( escape_regex "${KUBE_GIT_VERSION%%-*}" )"
-etcd_git_regex="$( escape_regex "${ETCD_GIT_VERSION%%-*}" )"
+etcd_version="$(echo "${ETCD_GIT_VERSION}" | sed -E "s/\-.*//g" | sed -E "s/v//")"
+etcd_git_regex="$( escape_regex "${etcd_version%%-*}" )"


raises eyebrow

etcd doesn't follow our regex rules

follow our version style rules

liggitt · 2016-09-27T14:23:21Z

pkg/cmd/server/etcd/etcdserver/run.go

+
+		select {
+		case <-e.Server.ReadyNotify():
+			glog.Infof("Started etcd at %s", etcdServerConfig.Address)


this seems wrong... if we reach this log line, we'll immediately fatal below?

It waits on the error channel.

liggitt · 2016-09-27T14:24:37Z

pkg/cmd/server/etcd/etcdserver/run.go

+
+// addressToURLs turns a host:port comma delimited list into an array valid
+// URL strings with the appropriate prefix for the TLS mode.
+func addressToURLs(addr string, isTLS bool) []string {


we're passing in bind addresses here... is https://0.0.0.0:4001 going to be valid?

Yes, same as before. The logic for calculating addresses simply moved deeper.

liggitt · 2016-09-27T14:25:11Z

pkg/cmd/server/etcd/etcdserver/server.go

-	}
-	osutil.HandleInterrupts()
-	s.Start()
-	osutil.RegisterInterruptHandler(s.Stop)


were the interrupt handlers important?

Yes, added them back.

Although now it's survivable.

smarterclayton · 2016-09-27T15:01:29Z

Impossible if they start older than 2.3.7 I believe.

On Tue, Sep 27, 2016 at 10:35 AM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test Running (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9346/)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10976 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_pydRwCoFuiEFulDnz5lZR_1V5WtJks5quSmtgaJpZM4J_xaZ
.

liggitt · 2016-09-27T15:13:31Z

pkg/cmd/server/etcd/etcdserver/run.go

+
+		select {
+		case <-e.Server.ReadyNotify():
+			glog.Infof("Started etcd at %s", etcdServerConfig.Address)


liggitt · 2016-09-27T15:15:08Z

pkg/cmd/server/etcd/etcdserver/run.go

+		cfg.ClientTLSInfo.CAFile = etcdServerConfig.ServingInfo.ClientCA
+		cfg.ClientTLSInfo.CertFile = etcdServerConfig.ServingInfo.ServerCert.CertFile
+		cfg.ClientTLSInfo.KeyFile = etcdServerConfig.ServingInfo.ServerCert.KeyFile
+		cfg.ClientTLSInfo.ClientCertAuth = len(cfg.ClientTLSInfo.CertFile) > 0


this should trigger off the ClientCA being specified, not the cert file

liggitt · 2016-09-27T15:15:22Z

pkg/cmd/server/etcd/etcdserver/run.go

+		cfg.PeerTLSInfo.CAFile = etcdServerConfig.PeerServingInfo.ClientCA
+		cfg.PeerTLSInfo.CertFile = etcdServerConfig.PeerServingInfo.ServerCert.CertFile
+		cfg.PeerTLSInfo.KeyFile = etcdServerConfig.PeerServingInfo.ServerCert.KeyFile
+		cfg.PeerTLSInfo.ClientCertAuth = len(cfg.PeerTLSInfo.CertFile) > 0


same here, len(ClientCA) > 0

smarterclayton · 2016-09-27T16:38:18Z

[test] idle.sh flake

liggitt · 2016-09-27T17:08:35Z

LGTM after squash of review commit

smarterclayton · 2016-09-27T17:14:02Z

[merge]

openshift-bot · 2016-09-27T17:17:36Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9381/) (Image: devenv-rhel7_5092)

openshift-bot · 2016-09-27T17:17:37Z

Evaluated for origin merge up to 604ff86

smarterclayton · 2016-09-27T21:16:30Z

[test] #11024

On Tue, Sep 27, 2016 at 4:48 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9367/)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10976 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p1ny4QTOFpIfwK0ZQ3ZpgM7VZ2BUks5quYEDgaJpZM4J_xaZ
.

openshift-bot · 2016-09-27T21:17:49Z

Evaluated for origin test up to 604ff86

openshift-bot · 2016-09-27T23:14:58Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9381/)

smarterclayton force-pushed the etcd_310 branch 2 times, most recently from 65d7764 to 0c64ae8 Compare September 18, 2016 16:34

smarterclayton changed the title ~~WIP - Etcd v3.1.0-alpha.0 with embedding and gRPC support~~ Etcd v3.1.0-alpha.0 with embedding and gRPC support Sep 18, 2016

smarterclayton force-pushed the etcd_310 branch 2 times, most recently from 173aba1 to fc95ba7 Compare September 18, 2016 23:59

smarterclayton force-pushed the etcd_310 branch from fc95ba7 to 742bfb3 Compare September 20, 2016 03:00

smarterclayton mentioned this pull request Sep 20, 2016

Default new developer clusters to etcd3 and protobuf serialization #10980

Merged

smarterclayton mentioned this pull request Sep 20, 2016

flake: hack/test-cmd.sh has failed: idle.sh:34: executing 'oc get pod -l app=idling-echo ...' #11004

Closed

liggitt reviewed Sep 27, 2016

View reviewed changes

smarterclayton force-pushed the etcd_310 branch from 742bfb3 to 8b70560 Compare September 27, 2016 14:27

liggitt suggested changes Sep 27, 2016

View reviewed changes

liggitt approved these changes Sep 27, 2016

View reviewed changes

smarterclayton added 4 commits September 27, 2016 13:13

bump(github.com/coreos/etcd):v3.1.0-alpha.1

e54f9ff

UPSTREAM: coreos/etcd: 6463: Must explicitly enable http2 for Go 1.7 TLS

f90520a

Switch to using the new 'embed' package to launch etcd

8151d00

etcd install and version test is broken

604ff86

smarterclayton force-pushed the etcd_310 branch from 2532c19 to 604ff86 Compare September 27, 2016 17:13

openshift-bot merged commit 2d77a91 into openshift:master Sep 28, 2016

Etcd v3.1.0-alpha.0 with embedding and gRPC support #10976

Etcd v3.1.0-alpha.0 with embedding and gRPC support #10976

Uh oh!

Conversation

smarterclayton commented Sep 18, 2016

Uh oh!

smarterclayton commented Sep 18, 2016

Uh oh!

smarterclayton commented Sep 19, 2016

Uh oh!

smarterclayton commented Sep 19, 2016

Uh oh!

smarterclayton commented Sep 20, 2016

Uh oh!

smarterclayton commented Sep 20, 2016

Uh oh!

smarterclayton commented Sep 20, 2016 via email

Uh oh!

smarterclayton commented Sep 21, 2016

Uh oh!

smarterclayton commented Sep 26, 2016

Uh oh!

smarterclayton commented Sep 26, 2016

Uh oh!

liggitt commented Sep 27, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarterclayton commented Sep 27, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarterclayton commented Sep 27, 2016 via email

Uh oh!

liggitt commented Sep 27, 2016

Uh oh!

smarterclayton commented Sep 27, 2016

Uh oh!

openshift-bot commented Sep 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Sep 27, 2016

Uh oh!

smarterclayton commented Sep 27, 2016

Uh oh!

openshift-bot commented Sep 27, 2016

Uh oh!

openshift-bot commented Sep 27, 2016

Uh oh!

Uh oh!

openshift-bot commented Sep 27, 2016 •

edited

Loading