Add details for field.Required #11034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm [merge] |
|
[Test]ing while waiting on the merge queue |
pweil-
force-pushed
the
field-required
branch
from
7c1bf05 to
d3c57ac
Compare
|
[test] |
|
re[test] |
|
flake #11016 and unrelated govet complaints |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9480/) (Image: devenv-rhel7_5101) |
Some fields are only required if other fields have certain values. This patch adds some additional error messaging to inform the user why these fields were necessary. Fixes issue openshift#7118 Signed-off-by: Stephen Gallagher <[email protected]>
pweil-
force-pushed
the
field-required
branch
from
d3c57ac to
d25995e
Compare
|
Evaluated for origin merge up to d25995e |
|
#10773 re[test] |
|
#11094 re[test] |
|
Evaluated for origin test up to d25995e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9480/) |
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #7118
@deads2k rebased and addressed the remaining feedback in #9198 (comment). Was there anything before this is ready to merge?