Remove -a flag from hack/test-integration.sh #11341
Conversation
|
do incremental builds actually work reliably? |
|
They seemed to work fine for me when I was working on #11269. |
|
@smarterclayton added the flag, any thoughts? LGTM |
|
It's fine to remove. It's not needed after changes made during the rebase. |
|
@stevekuznetsov Should |
|
Sounds like we can toss it |
|
Don't change build_static_binaries EDIT: without testing that it still works |
|
Edited the last, you need to verify that doesn't break base image builds. That's very old flags, I'm not 100% sure it's safe to remove it. |
|
[test] Let's see if base image builds still work via conformance tests. |
| @@ -237,7 +237,7 @@ readonly -f os::build::setup_env | |||
| # OS_BUILD_PLATFORMS - Incoming variable of targets to build for. If unset | |||
| # then just the host architecture is built. | |||
| function os::build::build_static_binaries() { | |||
| CGO_ENABLED=0 os::build::build_binaries -a -installsuffix=cgo $@ | |||
| CGO_ENABLED=0 os::build::build_binaries -installsuffix=cgo $@ | |||
There was a problem hiding this comment.
While we're here...
CGO_ENABLED=0 os::build::build_binaries -installsuffix=cgo "$@"
^ ^
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
enj
force-pushed
the
enj/i/test-integration.sh_speed
branch
from
48d026d to
9f6bde7
Compare
|
Evaluated for origin test up to 9f6bde7 |
|
@stevekuznetsov Any other tests you want to run? |
|
No, LGTM on extended tests building images and launching containerized Origin with them. [merge] |
|
Flake on #11381 |
|
re[merge] |
|
Flake on #11381 |
|
@enj you're still in the queue |
|
re[merge] |
|
Evaluated for origin merge up to 9f6bde7 |
|
Flake AWS Error |
|
I don't have the privilege to re-tag that one ... @danmcp |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10535/) (Base Commit: 84cddbc) (Image: devenv-rhel7_5235) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10533/) (Base Commit: 84cddbc) |
|
🎊 |
@smarterclayton I believe you added this build flag, but it makes it a real pain to work on the integration tests (it takes under 30 seconds to a do an incremental build vs 8 minutes to do a full build). If we need it for some reason, I could add a new config flag to
hack/test-integration.shsuch asOPENSHIFT_INCREMENTAL_BUILD.Signed-off-by: Monis Khan [email protected]