deploy: default maxSurge/maxUnavailable separately #11678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
mfojtik
reviewed
Nov 2, 2016
| @@ -351,7 +351,7 @@ func updateConditions(config deployapi.DeploymentConfig, newStatus *deployapi.De | |||
| if latestRC != nil { | |||
| switch deployutil.DeploymentStatusFor(latestRC) { | |||
| case deployapi.DeploymentStatusPending: | |||
| msg := fmt.Sprintf("Waiting on deployer pod for replication controller %q to be scheduled", latestRC.Name) | |||
| msg := fmt.Sprintf("Waiting deployer pod for replication controller %q to run", latestRC.Name) | |||
There was a problem hiding this comment.
Deployer pod waiting for replication controller :-)
There was a problem hiding this comment.
We are not waiting for the rc and that wording doesn't make it clear.
|
@mfojtik updated, ptal |
|
LGTM [merge] This is fixing BZ 1389170. |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11021/) (Image: devenv-rhel7_5305) |
|
Evaluated for origin merge up to 56f4626 |
|
#10228 [test] |
|
[test] |
|
Evaluated for origin test up to 56f4626 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11021/) (Base Commit: cf6ed4b) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores defaulting for maxSurge/maxUnavailable (regressed in #11090)
@mfojtik ptal
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1389170