Allow pv controller to recycle pvs, watch recycler pod events #11731
Conversation
| @@ -577,6 +577,11 @@ func init() { | |||
| Verbs: sets.NewString("get", "create", "delete"), | |||
| Resources: sets.NewString("pods"), | |||
| }, | |||
| // RecycleVolumeByWatchingPodUntilCompletion | |||
| { | |||
| Verbs: sets.NewString("watch"), | |||
There was a problem hiding this comment.
always need list as well, right? what behavior is being driven by watching events?
There was a problem hiding this comment.
also, the linked PR looks like it adds event recording... does this not need write permission to events?
There was a problem hiding this comment.
OK, I will add list as well. Seems to work without it because it's just watching recycler pod events in order to forward them to the PV being recycled. The actual check for whether the recycler has finished is still done by watching the recycler pod.
Yeah it needs write permissions, it already had them.
wongma7
force-pushed
the
recycler-watch
branch
from
a36e235 to
808302a
Compare
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11003/) (Image: devenv-rhel7_5305) |
|
Evaluated for origin merge up to 808302a |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 808302a |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11003/) (Base Commit: 2c40b4c) |
Needed due to new recycling behavior by #11259
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1390879
@jsafrane