Move verify-upstream-commits to a separate make target

[soltysh]

One another cherry-pick of #12056 against 1.3 branch, per @liggitt request. @stevekuznetsov fyi as well

[liggitt]

[test]

[soltysh]

Flake #10951

re-[test]

[openshift-bot]

Evaluated for origin test up to fbec109

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12001/) (Base Commit: 0955c1d)

[soltysh]

Hmmm... the failures are not related to the changes I've introduced. I wonder if test worked with 1.3 in the first place, @stevekuznetsov you might know?

[stevekuznetsov]

Origin's tests are not set up to handle 1.3 -- we are testing everything with Docker 1.12, etc. Until I have more bandwidth or someone volunteers to help these tests are going to remain mostly meaningless.

[soltysh]

With that in mind I'm closing this PR, if needed ping me I'll re-open it.

[liggitt]

tests were passing in the 1.3 release branch as of #11308 (comment)

is there a way to lock the image used to test? it's important we have the ability to verify fixes against our release branches

[liggitt]

@danmcp, thoughts on origin CI jobs for release branches?

[danmcp]

@liggitt I would worry about the maintenance of them. There are already a lot of previous release combinations we have a had time keeping running with the correct docker/golang.

[stevekuznetsov]

@liggitt there is a way, and we are using it in the OSE queue today. We just have to build from base_ami on every job -- if you have the time, looking at the OSE pull request job should give you the info you need to reconfigure all of Origin's jobs to do this. I just don't have the bandwidth for it right now.

[smarterclayton]

We really need release branches with CI. Probably needs to be folded into the other work going on though given limited attention.

[stevekuznetsov]

With the caveat that run time will be much longer, we should be able to copy the logic from the OSE job to build non-branch tests from the base AMI. We'd also need to update Rosie.

[smarterclayton]

Waiting for us to look at summit queue or improving Jenkins pr builder might be enough. Alternatively we should backport docker incompatibility bugs into the older branches. On Dec 30, 2016, at 11:49 AM, Steve Kuznetsov <[email protected]> wrote: With the caveat that run time will be much longer, we should be able to copy the logic from the OSE job to build non-branch tests from the base AMI. We'd also need to update Rosie. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pwCbF4Tmv4MnZedpctuEKZ-9I9gEks5rNTYjgaJpZM4LCtf0> .

[soltysh]

Closing due to age.