do s2i git cloning up front, not in s2i itself #12234
Conversation
|
[test] |
|
[testextended][extended:core(builds|image_ecosystem)] |
bparees
changed the title
bparees
changed the title
|
@csrwng ptal. This doesn't totally eliminate the "downloader" override because the concept of having a "downloader" is pretty intrinsic in s2i, but at least now the downloader we pass is basically a no-op and all the actual source cloning/setup is done up front in a similar way to how its done for docker builds. |
|
flake #12236 |
bparees
force-pushed
the
gitclone
branch
4 times, most recently
from
36e9098 to
4c6b98c
Compare
|
@csrwng ok, now ptal |
| download.sourceInfo = &sourceInfo.SourceInfo | ||
| revision := updateBuildRevision(s.build, sourceInfo) | ||
| if updateErr := retryBuildStatusUpdate(s.build, s.client, revision); updateErr != nil { | ||
| utilruntime.HandleError(fmt.Errorf("error: An error occured while updating the build status: %v", updateErr)) |
There was a problem hiding this comment.
fixed there and elsewhere.
|
One really minor comment, otherwise LGTM |
|
Evaluated for origin testextended up to b4be35c |
|
flake #11016 |
|
Evaluated for origin test up to b4be35c |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12493/) (Base Commit: 3d9cf71) |
|
[merge] |
|
Evaluated for origin merge up to b4be35c |
|
continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/928/) (Base Commit: 476887d) (Extended Tests: core(builds|image_ecosystem)) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12508/) (Base Commit: 07050d7) (Image: devenv-rhel7_5571) |
depends on openshift/source-to-image#660