Skip to content

UPSTREAM: 39496: Use privileged containers for host path e2e tests #12437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stevekuznetsov
Copy link
Contributor

Test containers need to run as spc_t in order to interact with the host
filesystem under /tmp, as the tests for HostPath are doing. Docker will
transition the container into this domain when running the container as
privileged.

Signed-off-by: Steve Kuznetsov [email protected]

@stevekuznetsov
Copy link
Contributor Author

@ncdc this doesn't apply cleanly -- why are we using the internal API package and not the external one here in the Origin copy of this test?

@ncdc
Copy link
Contributor

ncdc commented Jan 11, 2017

Because upstream moved from internal to v1 after 1.5.

@stevekuznetsov
Copy link
Contributor Author

@ncdc so what is the protocol here -- does this become a <drop> ?

@ncdc
Copy link
Contributor

ncdc commented Jan 12, 2017

No, just a normal UPSTREAM without any drop/carry modifier. But you need to be using api, not api/v1.

Test containers need to run as spc_t in order to interact with the host
filesystem under /tmp, as the tests for HostPath are doing. Docker will
transition the container into this domain when running the container as
privileged.

Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov
Copy link
Contributor Author

@ncdc any comments then before merge?

@ncdc
Copy link
Contributor

ncdc commented Jan 12, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to eb8415d

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to eb8415d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12807/) (Base Commit: 38831af)

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12834/) (Base Commit: 030a95b) (Image: devenv-rhel7_5667)

@openshift-bot openshift-bot merged commit 8a41d6f into openshift:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants