-
Notifications
You must be signed in to change notification settings - Fork 4.7k
UPSTREAM: 39496: Use privileged containers for host path e2e tests #12437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 39496: Use privileged containers for host path e2e tests #12437
Conversation
@ncdc this doesn't apply cleanly -- why are we using the internal API package and not the external one here in the Origin copy of this test? |
Because upstream moved from internal to v1 after 1.5. |
@ncdc so what is the protocol here -- does this become a |
No, just a normal UPSTREAM without any drop/carry modifier. But you need to be using api, not api/v1. |
d93f678
to
a71dddb
Compare
Test containers need to run as spc_t in order to interact with the host filesystem under /tmp, as the tests for HostPath are doing. Docker will transition the container into this domain when running the container as privileged. Signed-off-by: Steve Kuznetsov <[email protected]>
a71dddb
to
eb8415d
Compare
@ncdc any comments then before merge? |
[merge] |
Evaluated for origin merge up to eb8415d |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to eb8415d |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12807/) (Base Commit: 38831af) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12834/) (Base Commit: 030a95b) (Image: devenv-rhel7_5667) |
Test containers need to run as spc_t in order to interact with the host
filesystem under /tmp, as the tests for HostPath are doing. Docker will
transition the container into this domain when running the container as
privileged.
Signed-off-by: Steve Kuznetsov [email protected]