prevent Normalize from running twice on oadm drain #12651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
oops, @juanvallejo squash and I'll tag again. |
This patch avoids running template#Normalize twice on the description and example text of the `oadm drain` command. This fixes the broken link in the command's long description.
juanvallejo
force-pushed
the
jvallejo/fix-link-in-oadm-drain
branch
from
272960d to
b3949de
Compare
|
integration check flaked on #11438 re[test] |
|
[merge] |
|
check flaked on #12667 re[test] |
|
Evaluated for origin test up to b3949de |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13316/) (Base Commit: 59e57b1) |
|
Evaluated for origin merge up to b3949de |
|
flaked on #12667 [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13337/) (Base Commit: 39e4f8c) (Image: devenv-rhel7_5787) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1415985
This patch avoids running template#Normalize twice on the description
and example text of the
oadm draincommand. This fixes the broken linkin the command's long description.
Before
After
@openshift/cli-review