add persistent examples to quickstarts #12682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparees
force-pushed
the
persistent_templates
branch
from
19200af to
403ba23
Compare
bparees
force-pushed
the
persistent_templates
branch
from
403ba23 to
f02a0b4
Compare
|
@luciddreamz step 1. ptal. |
|
@luciddreamz bump |
|
@bparees Everything looks good here |
|
[merge] |
|
Evaluated for origin merge up to f02a0b4 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13386/) (Base Commit: ae0700c) (Image: devenv-rhel7_5797) |
|
@sdodson who typically handles pulling additional templates into OCP? That's the next stop for these. |
|
I generally have but I think this change would be pulled in by simply running roles/openshift_examples/examples_sync.sh and opening a PR with those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.