Add imagebuilder to origin-release Dockerfiles #12967
Conversation
|
Lgtm [merge] |
|
@marun
https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_integration_future/218/
failed
on ingress integration, do we depend on ":latest" images in integration?
On Feb 15, 2017, at 10:13 AM, OpenShift Bot <[email protected]> wrote:
continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/220/)
(Base Commit: 05377d4
<05377d4>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12967 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p0NN0iQLddiNhi3tLvFVeKTyyDWsks5rcxYRgaJpZM4MBjly>
.
|
|
[test] |
|
Yeah this is a problem with the test depending on :latest. It needs to
depend on a release image env var (which the router does today) and default
to latest if not set
On Feb 15, 2017, at 1:45 PM, OpenShift Bot <[email protected]> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/232/)
(Base Commit: c4879fc
<c4879fc>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12967 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p6RA4J4fBREvCLcbMqRrnTL7Tx8Xks5rc0fOgaJpZM4MBjly>
.
|
|
I actually figured out why this didn't work. It's not just networking. It's all image builds, because they have a generic FROM. To fix it, we either need to be explicit about the from via image builder, or tag multiple times. This is something OpenShift makes easy but is more irritating locally. We could make image builder tag multiple times if we had to. We don't put docker in any of our images today, and I'm hesitant to start for other reasons. We can definitely put it in the release builder if we have to, but we'll have to deal with version mismatches more (the generic client code does a much better job of it). |
|
@jakub we can tag multiple times now in image builder, that should unblock this PR by not making us need to do the latest tag with docker |
|
Looked like clayton is doing the bash in #13335 |
|
Yeah there were enough fixes I wanted to test together.
On Mar 10, 2017, at 7:20 AM, Steve Kuznetsov <[email protected]> wrote:
Looked like clayton is doing the bash in #13335
<#13335>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12967 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p_YDKq2PQL-dFbkpHY1NRhk7VsyTks5rkUADgaJpZM4MBjly>
.
|
|
This is scoped down to only the Dockerfile changes, [merge] |
|
Real failure I think
|
|
|
|
Evaluated for origin test up to c666127 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/138/) (Base Commit: 31e9bd0) |
|
[merge] |
|
@openshift-bot, the last build failed from the following flakes:
re[merge] |
|
Evaluated for origin merge up to c666127 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/59/) (Base Commit: 54af0f3) (Image: devenv-rhel7_6067) |
Add imagebuilder to origin-release versioned Dockerfiles, as a dependency for
hack/build-images.sh@smarterclayton || @stevekuznetsov PTAL
Closes #12934