Enhance new-app circular test to handle ImageStreamImage refs #13233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparees
requested changes
Mar 3, 2017
pkg/generate/app/cmd/newapp.go
Outdated
| @@ -823,6 +823,15 @@ func (c *AppConfig) followRefToDockerImage(ref *kapi.ObjectReference, isContext | |||
| return ©, nil | |||
| } | |||
|
|
|||
| if ref.Kind == "ImageStreamImage" { | |||
| // even if the associated tag for this ImageStreamImage matches a output ImageStreamTag, when the image | |||
| // is build it will have a new sha ... you are essentially using a single/unique older version of a image in the base | |||
|
[merge] |
|
Evaluated for origin merge up to 5b464bf |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 5b464bf |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/824/) (Base Commit: 87597f4) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/832/) (Base Commit: 71f5cfe) (Image: devenv-rhel7_6037) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug 1422378
https://bugzilla.redhat.com/show_bug.cgi?id=1422378
@csrwng ptal
(quick background - I went back and forth on translating the ImageStreamImage name to docker refs or ImageStreamTags, but then convinced myself that was unnecessary)
@openshift/devex fyi