correct the ways that routes are iterated over to be cleared #13246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there was an oversight in the way that the clear route status iterated
over the routes returned by
oc get routes -o jsonpath='{.items[*].metadata.name}' --namespace="${namespace}" 2>/dev/null
currently all routes are presented as one string that the server cannot find. Changed that
so that the routes are returned into an array and correctly iterated over so that the server
is given one route name at a time
Bug 1429364
Bug 1429398
|
@openshift/networking @knobunc PTAL |
|
[test] ... not that anything will actually test this. |
|
Evaluated for origin test up to edef4d1 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/866/) (Base Commit: 5e64198) |
|
LGTM |
|
[merge] @JacobTanenbaum we should probably prep a 1.5 branch PR for this too |
|
Evaluated for origin merge up to edef4d1 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/916/) (Base Commit: b1201dd) (Image: devenv-rhel7_6050) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was an oversight in the way that the clear route status iterated
over the routes returned by
oc get routes -o jsonpath='{.items[*].metadata.name}' --namespace="${namespace}" 2>/dev/null
currently all routes are presented as one string that the server cannot find.
change that so that the routes are returned into an array and correctly iterated over to present
to the server each route.
Bug 1429364 Link
Bug 1429398 Link