etcd clusters must negotiate to reach v3 mode, wait #13261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm [merge] |
|
should kubernetes/kubernetes#39821 have done this as well? |
|
[Test]ing while waiting on the merge queue |
|
Only embedded servers have to do it. |
Otherwise we can start making calls to the cluster while it is still in v2 mode.
smarterclayton
force-pushed
the
wait_for_capable
branch
from
73f175a to
9390478
Compare
|
Evaluated for origin test up to 9390478 |
|
ClusterVersion() can be nil, apparently. I have no version yet I must
negotiate, or something.
…On Mon, Mar 6, 2017 at 9:05 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test Running (
https://ci.openshift.redhat.com/jenkins/job/test_pull_
requests_origin_future/886/) (Base Commit: da719a3
<da719a3>
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13261 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p9A5dIUSy4sT21IcbiQQjuyvUbfCks5rjLtqgaJpZM4MUswM>
.
|
|
Evaluated for origin merge up to 9390478 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/887/) (Base Commit: da719a3) (Image: devenv-rhel7_6044) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/886/) (Base Commit: da719a3) |
1 similar comment
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/886/) (Base Commit: da719a3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we can start making calls to the cluster while it is still in v2 mode.
Fixes #12993
@liggitt