Skip to content

Use kube auth interfaces for union and group #13296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

enj
Copy link
Contributor

@enj enj commented Mar 8, 2017

Collapses a little bit of the shared interfaces.

Signed-off-by: Monis Khan [email protected]

@enj enj added this to the 1.6.0 milestone Mar 8, 2017
@enj
Copy link
Contributor Author

enj commented Mar 8, 2017

[test]

@enj enj requested a review from deads2k March 8, 2017 05:29
@enj
Copy link
Contributor Author

enj commented Mar 8, 2017

@deads2k PTAL whenever you get a chance.

xref: #13247

@deads2k
Copy link
Contributor

deads2k commented Mar 8, 2017

lgtm [merge]

@deads2k
Copy link
Contributor

deads2k commented Mar 8, 2017

re[merge]

@deads2k
Copy link
Contributor

deads2k commented Mar 8, 2017

@enj find the flake to reference and i'll rekick.

@enj
Copy link
Contributor Author

enj commented Mar 9, 2017

@deads2k not a flake - GCE is broken. Steve disabled the test suite so it shouldn't get in the way anymore.

@deads2k
Copy link
Contributor

deads2k commented Mar 9, 2017

[merge]

@stevekuznetsov
Copy link
Contributor

Your merge job had a deadlock on oc logs in the integration suite -- I aborted it as I didn't really want to wait for the timeout to hit since this was in the critical path for other merges.

@deads2k
Copy link
Contributor

deads2k commented Mar 9, 2017

Your merge job had a deadlock on oc logs in the integration suite -- I aborted it as I didn't really want to wait for the timeout to hit since this was in the critical path for other merges.

Known flake or fresh in this pull?

@stevekuznetsov
Copy link
Contributor

Really hard to tell without artifacts. We've had some sort of logs -f deadlock/output issues for year(s?) now ... Sorry for squashing, but the circumstances this morning were special.

@enj enj force-pushed the enj/f/group_adder/13247 branch from 35a6c57 to 561d3df Compare March 10, 2017 15:03
@enj
Copy link
Contributor Author

enj commented Mar 10, 2017

@stevekuznetsov did I break it somehow?

@stevekuznetsov
Copy link
Contributor

@enj yeah you did :\

@stevekuznetsov
Copy link
Contributor

(no, you didn't)

@enj
Copy link
Contributor Author

enj commented Mar 10, 2017

re[test] plz?

@deads2k
Copy link
Contributor

deads2k commented Mar 10, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 561d3df

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/133/) (Base Commit: d49d401)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 561d3df

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 11, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/48/) (Base Commit: 9e11eb4) (Image: devenv-rhel7_6067)

@openshift-bot openshift-bot merged commit b16fc52 into openshift:master Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants