Backport RPM build changes so CI works on release-1.5 #13610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to determine what RPM package version would be built from a given commit, the logic for determining the version needs to be split out from the script that builds RPMs. Now, if you are going to use `hack/build-rpm-release.sh` you can first call `os::build::rpm::format_nvr` to determine the NVR of the package you will build. Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
|
[test][merge] |
|
Evaluated for origin merge up to 9a14bfa |
|
Evaluated for origin test up to 9a14bfa |
|
I am assuming the diff for 1.4 would be a whole lot worse? |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/238/) (Base Commit: 3e12f6a) (Image: devenv-rhel7_6114) |
$ git log v1.4.0..HEAD --pretty=%h -- hack/ | wc -l
155 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/535/) (Base Commit: 3e12f6a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.