Prefer legacy kinds #13791

ncdc · 2017-04-17T19:33:56Z

We need to prefer legacy kinds so that calls to ObjectKinds(obj)
and resource.Mapper.InfoForObject() (used by oc run and oc expose)
return the legacy kinds for backwards compatibility against servers that
don't have the new api groups.

Fixes bug 1441755
https://bugzilla.redhat.com/show_bug.cgi?id=1441755

smarterclayton · 2017-04-17T19:38:19Z

[test]

We need to prefer legacy kinds so that calls to ObjectKinds(obj) and resource.Mapper.InfoForObject() (used by oc run and oc expose) return the legacy kinds for backwards compatibility against servers that don't have the new api groups.

ncdc · 2017-04-18T17:16:35Z

[test] #13802

ncdc · 2017-04-18T18:54:51Z

@stevekuznetsov I think I just hit #13713 - not sure if that's been resolved?

[test]

openshift-bot · 2017-04-18T19:05:26Z

Evaluated for origin test up to 164216c

openshift-bot · 2017-04-18T20:38:47Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/790/) (Base Commit: 8ad762c)

ncdc · 2017-04-18T20:39:47Z

About time I got a clean run. @smarterclayton @pweil- @mfojtik @soltysh @Kargakis @sttts @liggitt @deads2k any comments?

smarterclayton · 2017-04-18T20:52:08Z

pkg/template/api/helpers.go

+		// We currently add legacy types first to the scheme, followed by the types in the new api
+		// groups. We have to check all ObjectKinds and not just use the first one returned by
+		// ObjectKind().
+		gvks, _, err := kapi.Scheme.ObjectKinds(obj)
 		if err != nil {
 			return err
 		}

 		var targetVersion *unversioned.GroupVersion


This logic is really confused at this point - Codecs.CodecForVersions accepts a runtime.GroupVersioner (which gvks satisfies) which should be enough to ensure you get the right object, so you shouldn't have to pass a single target version (you can instead pass multiple). And it raises the question about whether we should even be using this logic for templates vs dealing with unstructured.

However, I guess it can stand for now.

smarterclayton · 2017-04-18T20:52:24Z

LGTM [merge]

stevekuznetsov · 2017-04-18T20:53:52Z

@ncdc working on resolving that one

mfojtik · 2017-04-19T10:10:12Z

flake: #13650

[merge]

ncdc · 2017-04-19T17:01:04Z

Multiple issues:

+ sudo python hack/determine_install_upgrade_version.py atomic-openshift-utils-3.6.30-1.git.0.d88b698.el7.noarch
python: can't open file 'hack/determine_install_upgrade_version.py': [Errno 2] No such file or directory
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: INSTALL ANSIBLE ATOMIC-OPENSHIFT-UTILS ##########

+ cd /home/origin
+ sudo chmod a+x /etc/ /etc/origin/ /etc/origin/master/
chmod: cannot access ‘/etc/origin/’: No such file or directory
chmod: cannot access ‘/etc/origin/master/’: No such file or directory
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: EXPOSE THE KUBECONFIG ##########

PLAY [sync the remote host with code from the remote repository] ***************

TASK [Gathering Facts] *********************************************************
fatal: [172.18.13.56]: UNREACHABLE! => {
    "changed": false, 
    "generated_timestamp": "2017-04-19 11:40:20.572697", 
    "msg": "Failed to connect to the host via ssh: ssh: connect to host 172.18.13.56 port 22: Connection refused\r\n", 
    "unreachable": true
}

[merge]

ncdc · 2017-04-20T01:08:48Z

[merge]

ncdc · 2017-04-21T11:22:15Z

[merge]

…

On Fri, Apr 21, 2017 at 7:21 AM OpenShift Bot ***@***.***> wrote: continuous-integration/openshift-jenkins/merge FAILURE ( https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/405/) (Base Commit: b95420a <b95420a> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13791 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABYnZKYRKJWnLqCk2KNMllRqmKlChWks5ryJE-gaJpZM4M_elf> .

ncdc · 2017-04-21T13:16:33Z

[merge]

…

On Fri, Apr 21, 2017 at 9:05 AM OpenShift Bot ***@***.***> wrote: continuous-integration/openshift-jenkins/merge FAILURE ( https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/406/) (Base Commit: b95420a <b95420a> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13791 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABYsRIt7-4IyUyX-elP5V5vVU23K5jks5ryKmggaJpZM4M_elf> .

ncdc · 2017-04-22T11:52:31Z

[merge]

…

On Sat, Apr 22, 2017 at 1:35 AM OpenShift Bot ***@***.***> wrote: continuous-integration/openshift-jenkins/merge FAILURE ( https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/410/) (Base Commit: c106caf <c106caf> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13791 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABYp3wbKYVNRnrKlCfmIxaPWX9mqYJks5ryOWfgaJpZM4M_elf> .

smarterclayton · 2017-04-23T20:07:54Z

[merge]

…

On Sat, Apr 22, 2017 at 8:05 AM, OpenShift Bot ***@***.***> wrote: continuous-integration/openshift-jenkins/merge FAILURE ( https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/428/) (Base Commit: c106caf <c106caf> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13791 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p2WaAGftQxA31OmNsSUq4tBzYu_-ks5ryez_gaJpZM4M_elf> .

ncdc · 2017-04-24T11:56:36Z

[merge]

ncdc · 2017-04-24T13:13:05Z

[merge]

openshift-bot · 2017-04-24T13:13:24Z

Evaluated for origin merge up to 164216c

openshift-bot · 2017-04-24T13:13:32Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/458/) (Base Commit: 53a4d1b) (Image: devenv-rhel7_6172)

ncdc · 2017-04-24T14:29:23Z

About time

ncdc added 2 commits April 18, 2017 10:21

Prefer legacy kinds

5dd6cae

We need to prefer legacy kinds so that calls to ObjectKinds(obj) and resource.Mapper.InfoForObject() (used by oc run and oc expose) return the legacy kinds for backwards compatibility against servers that don't have the new api groups.

Check multiple GVKs in AddObjectsToTemplate

164216c

ncdc force-pushed the prefer-legacy-kinds branch from 907bf7b to 164216c Compare April 18, 2017 14:21

smarterclayton reviewed Apr 18, 2017

View reviewed changes

openshift-bot merged commit d41996f into openshift:master Apr 24, 2017

Prefer legacy kinds #13791

Prefer legacy kinds #13791

Uh oh!

Conversation

ncdc commented Apr 17, 2017

Uh oh!

smarterclayton commented Apr 17, 2017

Uh oh!

ncdc commented Apr 18, 2017

Uh oh!

ncdc commented Apr 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 18, 2017

Uh oh!

openshift-bot commented Apr 18, 2017

Uh oh!

ncdc commented Apr 18, 2017

Uh oh!

smarterclayton Apr 18, 2017

Choose a reason for hiding this comment

Uh oh!

smarterclayton commented Apr 18, 2017

Uh oh!

stevekuznetsov commented Apr 18, 2017

Uh oh!

mfojtik commented Apr 19, 2017

Uh oh!

ncdc commented Apr 19, 2017

Uh oh!

ncdc commented Apr 20, 2017

Uh oh!

ncdc commented Apr 21, 2017 via email

Uh oh!

ncdc commented Apr 21, 2017 via email

Uh oh!

ncdc commented Apr 22, 2017 via email

Uh oh!

smarterclayton commented Apr 23, 2017 via email

Uh oh!

ncdc commented Apr 24, 2017

Uh oh!

ncdc commented Apr 24, 2017

Uh oh!

openshift-bot commented Apr 24, 2017

Uh oh!

openshift-bot commented Apr 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ncdc commented Apr 24, 2017

Uh oh!

Uh oh!

ncdc commented Apr 18, 2017 •

edited

Loading

openshift-bot commented Apr 24, 2017 •

edited

Loading