deploy: add cancel condition reason and move reasons to types #13813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API looks fine |
|
lgtm [merge] |
|
[Test]ing while waiting on the merge queue |
mfojtik
force-pushed
the
cancel-condition
branch
from
aa36fe0 to
5f32644
Compare
|
updated extended tests to point to new location for reasons... [merge] |
|
Evaluated for origin test up to 5f32644 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/876/) (Base Commit: c106caf) |
1 similar comment
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/876/) (Base Commit: c106caf) |
|
[merge]
…On Sun, Apr 23, 2017 at 3:21 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test SUCCESS (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/876/)
(Base Commit: c106caf
<c106caf>
)
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#13813 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p-aZTiNCn21OnkrCq4lCfnfAfo0uks5ry6TCgaJpZM4NBiOT>
.
|
|
[merge] |
|
[merge]
…On Mon, Apr 24, 2017 at 5:05 AM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/455/)
(Base Commit: 53a4d1b
<53a4d1b>
)
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#13813 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pz61-XyIlzPy92f9xPQsl4lR132Oks5rzGXWgaJpZM4NBiOT>
.
|
|
Evaluated for origin merge up to 5f32644 |
|
[merge] again |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/469/) (Base Commit: 9334452) (Image: devenv-rhel7_6177) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13800
First commit introduces
RolloutCancelledfor rollouts that has been cancelled (and thus failed their progression) instead of having theProgressDeadlineExceededreason there.Second commit moves the reasons from utils to types as they are not meant to be changed since changing them might violate the API backward compatibility.
@Kargakis @openshift/api-review