-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Bug 1421643 - Fix network diagnostics timeouts #13851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1421643 - Fix network diagnostics timeouts #13851
Conversation
waitForNetworkPod() is called from few places and it has a fixed timeout of 82 seconds which was insufficient in few cases where the network bandwidth is low or network latency is high. This change will make waitForNetworkPod() to take custom timeout value based on the operation performed.
at least 50% of test pods.
@openshift/networking PTAL |
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rajatchopra @dcbw if you like it, then why no [test] or [merge] ? |
Evaluated for origin test up to 6f48029 |
Evaluated for origin merge up to 6f48029 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/895/) (Base Commit: 53a4d1b) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/474/) (Base Commit: 3271ed1) (Image: devenv-rhel7_6177) |
No description provided.