master: only one place for storage GVRs #14018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #13653 (comment) |
|
[test] |
mfojtik
reviewed
May 3, 2017
| {"user.openshift.io", "v1", "groups"}, | ||
| {"user.openshift.io", "v1", "users"}, | ||
| {"user.openshift.io", "v1", "identities"}, | ||
| // storage versions: use legacy group name "" for all resources that existed when apigroups were introduced |
There was a problem hiding this comment.
maybe a small const will make this better? LegacyGroup or something :-)
sttts
force-pushed
the
sttts-legacy-storage-versions
branch
from
b4ac0bc to
5ad58fa
Compare
|
@mfojtik ptal |
|
re[test] |
sttts
force-pushed
the
sttts-legacy-storage-versions
branch
from
5ad58fa to
a6c20bf
Compare
|
re[test] |
sttts
force-pushed
the
sttts-legacy-storage-versions
branch
from
a6c20bf to
c0e4560
Compare
|
Evaluated for origin test up to c0e4560 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1262/) (Base Commit: 3e446c7) |
|
@mfojtik ptal |
|
LGTM |
|
[merge] |
|
Evaluated for origin merge up to c0e4560 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/654/) (Base Commit: 4af1533) (Image: devenv-rhel7_6230) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were overwriting the pkg/cmd/server/origin/rest.StorageOptions values in master_config.go's BuildStorageFactory.