Skip to content

Generated image clients #14042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2017
Merged

Generated image clients #14042

merged 3 commits into from
May 15, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented May 4, 2017

This adds generated clients for the following resources:

  • ImageStream
  • ImageStreamTag
  • ImageStreamImport
  • ImageSignature

I've also updated make update to build before generating completions.

@ncdc ptal
@smarterclayton fyi, since you're gonna needs this in your trigger PR

@soltysh
Copy link
Contributor Author

soltysh commented May 4, 2017

[test]

@soltysh
Copy link
Contributor Author

soltysh commented May 4, 2017

Apparently we generate too much, so I've dropped ImageStreamTag, ImageStreamImport and ImageSignature, since for those List is not needed, but there's no current way to prevent generator from generating those, yet.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to ea7c0a8

@ncdc
Copy link
Contributor

ncdc commented May 4, 2017

Apparently we generate too much

What do you mean?

@soltysh
Copy link
Contributor Author

soltysh commented May 4, 2017

@ncdc I got List() generated for IST, ISI and ImageSignature although none of them has *List object, which result in integration build failure. Generation should look for existence of those and generate only if present. Additionally those 3 objects have only limited set of methods available. That's why I decided not to generate them, yet.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1147/) (Base Commit: dcd60bd)

@smarterclayton
Copy link
Contributor

No comments from me

@soltysh
Copy link
Contributor Author

soltysh commented May 15, 2017

I assume no objections is ok to merge.

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to ea7c0a8

@openshift-bot
Copy link
Contributor

openshift-bot commented May 15, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/651/) (Base Commit: b581bfe) (Image: devenv-rhel7_6228)

@openshift-bot openshift-bot merged commit be73656 into openshift:master May 15, 2017
@soltysh soltysh deleted the image_clients branch May 15, 2017 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants