fix the help text in the clear-route-status script #14130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knobunc @stevekuznetsov PTAL |
|
Defer to @knobunc |
knobunc
requested changes
May 10, 2017
images/router/clear-route-status.sh
Outdated
| ./clear-route-status.sh [namespace] [route-name | ALL] | ||
|
|
||
|
|
||
| Example Usage: |
There was a problem hiding this comment.
How about renaming that to:
Example Usage
--------------
QA reported that they felt the help text was not clear enough. I Tagged the examples as examples and reworded a section Bug: 1440620
JacobTanenbaum
force-pushed
the
fix-helptext
branch
from
4a7e7d6 to
1599d80
Compare
|
[test] |
|
[merge] |
|
[test] |
|
Evaluated for origin test up to 1599d80 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1408/) (Base Commit: f24a57f) |
|
flake #13271 |
|
re[merge] |
|
@openshift-bot, the last build failed from the following flakes:
re[merge] |
|
Evaluated for origin merge up to 1599d80 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/672/) (Base Commit: 713fd08) (Image: devenv-rhel7_6235) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA reported that they felt the help text was not clear enough.
I Tagged the examples as examples and reworded a section
Bug: 1440620 Link